search

ammarahm-ed / react-native-actions-sheet

A Cross Platform(Android, iOS & Web) ActionSheet with a flexible api, native performance and zero dependency code for react native. Create anything you want inside ActionSheet.
https://rnas.vercel.app
MIT License
1.49k stars 121 forks source link

Latest version throws "@shopify/flash-list" error. #312

Closed sadewole closed 8 months ago

sadewole commented 1 year ago

Installing the latest version throws a build error. Apparently "@shopify/flash-list" was used in one of the files but couldn't be resolved.

iOS Bundling failed 434ms Unable to resolve "@shopify/flash-list" from "node_modules/react-native-actions-sheet/dist/src/views/FlashList.js"

Medkhat commented 1 year ago

Hi there! I also had this problem and installed this package and then was another issue that should have been installed react-native-gesture-handler package. So, I installed this package too then it worked. Maybe try!

1) Install @shopify/flash-list; 2) Install react-native-gesture-handler;

Dror-Bar commented 1 year ago

This would be useful to mention in the installation documentation

z1haze commented 10 months ago

yeah, first time checking out this library, and I read ...and zero dependency code for react native. in the introduction. not a great start to my experience.

Medkhat commented 10 months ago

@z1haze Yeah, but when you will start using this package, it's really cool. I have tried using the @gorhom/bottom-sheet, but this package requires the react-native-reanimated. So, when I installed and configured, my application crashes on each reboot cause of react-native-reanimated...

yvbeek commented 9 months ago

Is the @shopify/flash-list really necessary though? It is normally used in scenarios where performance is really key, where the user can scroll through a long list. Wouldn't that be a bit overkill for a small actionsheet? It really adds to the (indirect) dependencies.