search

ammarahm-ed / react-native-actions-sheet

A Cross Platform(Android, iOS & Web) ActionSheet with a flexible api, native performance and zero dependency code for react native. Create anything you want inside ActionSheet.
https://rnas.vercel.app
MIT License
1.49k stars 121 forks source link

Not working in release mode with new arch enabled (72.6) #317

Open JohnathanWhite opened 11 months ago

JohnathanWhite commented 11 months ago

Works in debug but with a release build (w/ new arch) the sheet is not visible.

mauricedoepke commented 10 months ago

I was able to solve this issue for me. I noticed, that directly using the ActionsSheets work, only usage via the SheetManager was broken.

With a bit more debugging, I noticed, that the file with all my registerSheet functions was not imported anywhere and thus the sheets never actiolly got registered. For some reason this file was stil run in dev mode and also in expo sdk 47 release mode.

So I suspect it was most likely not event a react native issue, but a change in the metro bundler and the way it handles non imported files, that caused this issue for me.

TLDR: I forgot to register the actions sheets.

Does that fix it for you as well @JohnathanWhite ?

OFD16 commented 2 months ago

I have the same problem, the react-native-modal package does not work in the same release mode (apk) as the react-native-actions-sheets package. I think it's a general problem that I can see.

How can we solve this problem, I opened a new topic about it (issue381)

those packages have problem in android release mode (apk) render problem. They are not working as in issue you can check. android > gradle.properties newArchEnabled=true