haresh4d
commented
2 years ago @ammarahm-ed and @mikehardy together! It will be a great library. We also want native ads and other ads format at the same place.
Open mikehardy opened 2 years ago
haresh4d
commented
2 years ago @ammarahm-ed and @mikehardy together! It will be a great library. We also want native ads and other ads format at the same place.
mikehardy
commented
2 years ago Haha I mostly want maintainers supporting each other by pooling effort, but only if it seems like a good idea to everyone of course :-), cheers
wjaykim
commented
2 years ago I had contributed to this library, too, it would be cool if we can join forces together in one great library.
ammarahm-ed
commented
2 years ago Hey Mike, it's actually surprising that you have considered opening an issue here and asking for contribution at react-native-google-mobile-ads which is rare and I thank you for that.
I just went through the work you all have put together and it looks awesome I think. And it's great that finally there is a community backed, well tested library for everyone to use.
I have maintained this library for over 2 years now even though I don't have any apps/products that use ads and it has come quite far with support from the community which is great.
I will be happy to contribute all of the work here into react-native-google-mobile-ads. However please note that this ad format unlike other ad formats is quite complex and difficult to implement which is why it sits here as a separate library. In the current state, the library has native ads, mediation and ad preloading support (not released yet).
Currently I am fasting as it's Ramadan here. I will send a PR in the first half of next month with an initial implementation. If there's anything else please let me know.
mikehardy
commented
2 years ago Ramadan Mubarak @ammarahm-ed :-)
Yes the complexity is the thing that really gives me pause, but...there's no avoiding it. I waited to reach out until I was pretty sure I had worked through all the other collaborators PRs so that I would have proper time to devote to getting native ads working well. I guess we won't know if we don't try?
As with all things Open Source: there's never a rush, so whenever is a good time. I'm really happy that you are willing to consider it though! If we do a good job we'll have an even larger community plus multiple maintainers (some of which make their sole living by ad-supported apps) which will hopefully make it better for users and for us doing the maintenance
Cheers
haresh4d
commented
2 years ago Ramadan Muabarak @ammarahm-ed
I know you must be celebrating the holy festival but please if you get time in between or after the Ramadan look into the #256
Thank you for providing such a beautiful library.
ammarahm-ed
commented
2 years ago @mikehardy It won't take very long since we already have 95% of the work completed here and native ads are in use in many production apps already. So we just have to port the code from here to there.
@haresh4d I will look into the issue.
adamsadiq7
commented
1 year ago Is there any update on the above guys? 👀
mikehardy
commented
1 year ago Nothing over in the other repo and we have hit the summer vacations/ travel part of my year so I will not be a great collaborator myself for about another month. But I'd still love to work together of course 🙂
ammarahm-ed
commented
1 year ago @mikehardy Hi, I have been jam packed with work for the past few months. I hope to start off on this weekend and will open a PR soon!
pairohit305
commented
1 year ago is PR ready?
Lurtroxx
commented
1 year ago Any update on this!? Excited for it.
vshalhdw
commented
1 year ago We are looking for this. Kindly make this happen. Thank you.
mikehardy
commented
1 year ago Kindly make this happen.
I could be wrong, but I don't think that's how open source works...if you really need it, you gotta do it...
vshalhdw
commented
1 year ago Yeah did it (or had to do it).
Kindly make this happen.
I could be wrong, but I don't think that's how open source works...if you really need it, you gotta do it...
TaylorDale
commented
7 months ago Open to contributing to a bounty for this, let me know how if anyone is up for the work
haresh4d
commented
7 months ago Yeah did it (or had to do it).
Kindly make this happen.
I could be wrong, but I don't think that's how open source works...if you really need it, you gotta do it...
Have you done it?
Hey @ammarahm-ed :wave:!
The module you've built here is fantastic - I think you might be the only person supporting native ads at the moment on react-native?
I'm the primary maintainer of react-native-firebase on behalf of Invertase, so for a long while I was in charge of making sure @react-native-firebase/admob worked as an official contract....until firebase upstream pulled AdMob out completely.
It took me a while, but I finally extracted the admob package and got it going again as a standalone repo with a ton of help from @dylancom. Then we asked @birgernass if they would join with us to handle user consent management (they did! It's awesome), and finally @wjaykim in order to get the hooks support from their module and have one module with more maintainers (they did! It is also awesome).
https://github.com/invertase/react-native-google-mobile-ads/graphs/contributors
The only thing we're missing over there is - you guessed it - native ads. I hate the idea of implementing things twice in two places unless there is a really good reason. And I love the idea of having multiple maintainers helping each other instead of all fragmented out. Maintaining a module is hard work and it's not much fun solo. I'm good at CI, releases, issue triage, and example app maintenance long-term with Invertase's support, so I can offer a stable well-maintained home for code if you want to join us.
What do you think? Want to help us bring native ad support to https://github.com/invertase/react-native-google-mobile-ads ?