ammarahm-ed / react-native-mmkv-storage

An ultra fast (0.0002s read/write), small & encrypted mobile key-value storage framework for React Native written in C++ using JSI
https://rnmmkv.now.sh
MIT License
1.56k stars 109 forks source link

[Bug] Issues upgrading to react-native v0.71 #316

Closed Dajust closed 1 year ago

Dajust commented 1 year ago

Describe the bug Trying to upgrade to RN v0.71 but keep getting the following error

FAILURE: Build failed with an exception.

* Where:
Build file '/.../node_modules/react-native-mmkv-storage/android/build.gradle' line: 138

* What went wrong:
A problem occurred evaluating project ':react-native-mmkv-storage'.
> Expected directory '/.../node_modules/react-native-mmkv-storage/android/../../../node_modules/react-native/android' to contain exactly one file, however, it contains no files.

To Reproduce Steps to reproduce the behavior:

  1. upgrade to RN v0.71
  2. Rebuild react-native android
  3. See error

Expected behavior react-native-mmkv-storage should continue working on the latest version of RN.

Screenshots If applicable, add screenshots to help explain your problem.

Platform Information:

Additional context Add any other context about the problem here.

petrlz63 commented 1 year ago

+1

WrathChaos commented 1 year ago

I am having the same problem. @ammarahm-ed Can you take a look at this?

playset commented 1 year ago

+1, how to fix this?

japhet247 commented 1 year ago

+1

WrathChaos commented 1 year ago

I believe this is going to resolve this issue: https://github.com/ammarahm-ed/react-native-mmkv-storage/commit/729a85f616b6ef4ec457e7cc9c8b6fa494d3dc7f

Ahmedhamed77 commented 1 year ago

I believe this is going to resolve this issue: 729a85f when this will be released?

ammarahm-ed commented 1 year ago

I'll make a release soonish. Hopefully today.

ammarahm-ed commented 1 year ago

Fixed in 0.9.0.

WrathChaos commented 1 year ago

Thank you for the fix :) @ammarahm-ed