ammaratef45 / Attendance

Application to be used for attendance registeration
MIT License
32 stars 15 forks source link

#50 added endpoint for getting info #96

Closed ammaratef45 closed 5 years ago

ammaratef45 commented 5 years ago

PR for #50

codecov[bot] commented 5 years ago

Codecov Report

Merging #96 into master will increase coverage by 3.01%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   41.12%   44.14%   +3.01%     
==========================================
  Files           6        7       +1     
  Lines         231      256      +25     
==========================================
+ Hits           95      113      +18     
- Misses        136      143       +7
Impacted Files Coverage Δ
attendance/lib/backend/user.dart 73.77% <0%> (-2.51%) :arrow_down:
attendance/lib/backend/api.dart 78.37% <100%> (+5.04%) :arrow_up:
attendance/lib/backend/attendance.dart 68.75% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e740acd...76cc877. Read the comment docs.

0crat commented 5 years ago

Job #96 is already in scope

0crat commented 5 years ago

This pull request #96 is assigned to @bahaaib/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @ammaratef45/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; @bahaaib/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

0crat commented 5 years ago

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @ammaratef45/z

Bahaaib commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@bahaaib Thanks for your request. @ammaratef45 Please confirm this.

ammaratef45 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@ammaratef45 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@ammaratef45 Oops, I failed. You can see the full log here (spent 2min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 22113
+ echo '1.68.2 70c246ce3'
1.68.2 70c246ce3
+ date
Wed May  8 14:27:40 CEST 2019
+ uptime
 14:27:40 up 144 days,  3:57,  0 users,  load average: 6.29, 5.93, 5.68
+ ff=default
+ image=ammaratef45/flutter:v3
+ rebase=false
+ head_branch=master
+ pull_title='#50 added endpoint for getting info'
+ author=ammaratef45
+ directory=
+ head=git@github.com:ammaratef45/Attendance.git
+ pull_id=96
+ fork=git@github.com:ammaratef45/Attendance.git
+ fork_branch=50
+ squash=false
+ vars=('--env=head=git@github.com:ammaratef45/Attendance.git' '--env=pull_id=96' '--env=fork=git@github.com:ammaratef45/Attendance.git' '--env=fork_branch=50' '--env=head_branch=master' '--env=pull_title=#50 added endpoint for getting info' '--env=author=ammaratef45' '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:ammaratef45/Attendance.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=96'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:ammaratef45/Attendance.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=50'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#50 added endpoint for getting info'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=ammaratef45'\''\'\'''\'''\'' '\'';'\'' '\''flutter doctor'\'' '\'';'\'' '\''cd attendance'\'' '\'';'\'' '\''chmod +x cleanENV.sh && ./cleanENV.sh'\'' '\'';'\'' '\''flutter packages get'\'' '\'';'\'' '\''. exportEnvVars.sh >/dev/null'\'' '\'';'\'' '\''flutter test'\'' '\'';'\'' '\''flutter -v build apk'\'' '\'';'\'' '\''. /etc/profile.d/rvm.sh'\'' '\'';'\'' '\''pdd -f /dev/null -v'\'' '\'';'\'' )')
+ scripts=('export '\''head=git@github.com:ammaratef45/Attendance.git'\''' ';' 'export '\''pull_id=96'\''' ';' 'export '\''fork=git@github.com:ammaratef45/Attendance.git'\''' ';' 'export '\''fork_branch=50'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#50 added endpoint for getting info'\''' ';' 'export '\''author=ammaratef45'\''' ';' 'flutter doctor' ';' 'cd attendance' ';' 'chmod +x cleanENV.sh && ./cleanENV.sh' ';' 'flutter packages get' ';' '. exportEnvVars.sh >/dev/null' ';' 'flutter test' ';' 'flutter -v build apk' ';' '. /etc/profile.d/rvm.sh' ';' 'pdd -f /dev/null -v' ';')
+ container=ammaratef45_attendance_96
+ as_root=true
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:ammaratef45/Attendance.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''head=git@github.com:ammaratef45/Attendance.git'\''' ']'
+ cd ..
+ cat
+ '[' true = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''head=git@github.com:ammaratef45/Attendance.git'\''' ';' 'export '\''pull_id=96'\''' ';' 'export '\''fork=git@github.com:ammaratef45/Attendance.git'\''' ';' 'export '\''fork_branch=50'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#50 added endpoint for getting info'\''' ';' 'export '\''author=ammaratef45'\''' ';' 'flutter doctor' ';' 'cd attendance' ';' 'chmod +x cleanENV.sh && ./cleanENV.sh' ';' 'flutter packages get' ';' '. exportEnvVars.sh >/dev/null' ';' 'flutter test' ';' 'flutter -v build apk' ';' '. /etc/profile.d/rvm.sh' ';' 'pdd -f /dev/null -v' ';'
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly
ammaratef45 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@ammaratef45 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@ammaratef45 Done! FYI, the full log is here (took me 6min)

0crat commented 5 years ago

Job #96 is not in the agenda of @bahaaib/z, can't retrieve data and time of add

0crat commented 5 years ago

Job was finished in 6 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

Quality is low, no payment, see §31:

0crat commented 5 years ago

The job #96 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @ammaratef45/z