ammaratef45 / Attendance

Application to be used for attendance registeration

MIT License

32 stars 15 forks source link

#59 use save in attendance instead of using the db #97

Closed ammaratef45 closed 5 years ago

ammaratef45 commented 5 years ago

PR for #59

0crat commented 5 years ago

This pull request #97 is assigned to @bahaaib/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @ammaratef45/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; @bahaaib/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

0crat commented 5 years ago

Job #97 is already in scope

codecov[bot] commented 5 years ago

Codecov Report

Merging #97 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   41.12%   41.12%           
=======================================
  Files           6        6           
  Lines         231      231           
=======================================
  Hits           95       95           
  Misses        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e32812...e740acd. Read the comment docs.

0crat commented 5 years ago

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @ammaratef45/z

Bahaaib commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@bahaaib Thanks for your request. @ammaratef45 Please confirm this.

ammaratef45 commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@ammaratef45 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@ammaratef45 Done! FYI, the full log is here (took me 6min)

0crat commented 5 years ago

Job #97 is not in the agenda of @bahaaib/z, can't retrieve data and time of add

0crat commented 5 years ago

Job was finished in 5 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

Quality is low, no payment, see §31:

0crat commented 5 years ago

The job #97 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @ammaratef45/z