search

ammargitham / WallFlow

Wallpaper app for Android using Jetpack Compose
GNU General Public License v3.0
325 stars 18 forks source link

Feature Request: Light and Dark wallpapers #49

Closed denizenging closed 5 months ago

denizenging commented 8 months ago

It'd be nice if the app allowed to mark some wallpapers to be used during light mode, dark mode, and maybe even when Extra Dim is on (which is available on android 12+), and auto-rotate the wallpapers that are marked within the current mode.

This might be more complicated than one might think (in terms of combinations, of course). For instance, one might wanna use a wallpaper for light mode OR dark mode, independently of Exra Dim, as well as when Extra Dim AND dark mode, or only Extra Dim is on, independetly of dark or light mode. These are to take into account.

Thanks for the app!

ammargitham commented 8 months ago

Sounds like a nice feature to have. I will discuss more once I get to this.

ammargitham commented 8 months ago

Regarding the extra dim setting, would it be used only with dark wallpapers? Like if the extra dim is on with the light mode, do you want mark light wallpapers separately for those?

denizenging commented 8 months ago

Regarding the extra dim setting, would it be used only with dark wallpapers? Like if the extra dim is on with the light mode, do you want mark light wallpapers separately for those?

I would highly believe that no one would ever want to use extra dim with light mode. I let you decide, though. If it's simpler without that combination, I'd say do it without.

ammargitham commented 8 months ago

I'll add a checkmark for extra dim only when the user marks the image as dark.

one might wanna use a wallpaper for light mode OR dark mode, independently of Exra Dim, as well as when Extra Dim AND dark mode, or only Extra Dim is on, independetly of dark or light mode

As for this, I have to revamp how the sources are set for each target (lock or home screen). I think I will work on #51 along with this. But I am traveling starting next week for a month, so progress will be slow.

denizenging commented 8 months ago

Sounds nice. Wish you a great journey!