Closed Lucki closed 5 months ago
It seems you have a lot of Favorites (around 4k) which is causing the SQL statement to fail.
@Lucki Do you really have so many Favorites? I need confirmation before I look into resolving this. Or else the bug might be something else.
Hm, it certainly sounds like alot. I marked quite a bunch of darker wallpapers in the beginning, so it seems possible? I sometimes use the favorites to get a pool of dark-ish wallpaper. The light/dark button is more recent than those favorites.
Maybe I indeed shouldn't import them into plus version… My hope is that there's a model for the automatic thing that can decide if a wallpaper has a brighter appearance, throw that away and search for another one, which is hopefully darker. Or that the newish light/dark can somehow decide by itself, I have to explore that function further.
Anyway, it's possible that the amount is the culprit. If it isn't possible to fix, then I'm absolutely not disappointed, but the limitation should be stated somehow somewhere.
Even then 4k seems like a lot to me. Is your phone by any chance rooted? That would help in debugging this further.
My hope is that there's a model for the automatic thing that can decide if a wallpaper has a brighter appearance, throw that away and search for another one, which is hopefully darker. Or that the newish light/dark can somehow decide by itself, I have to explore that function further.
The model in the Plus version currently is only for cropping wallpapers. It doesn't detect light/dark wallpapers
Ah, damn. I haven't looked into the model thing too deeply yet. Maybe I'll craft a feature request out of it if it bothers me too much :smile:
My phone is actually rooted, yes.
Awesome. Go into /data/data/com.ammar.wallflow/databases
and send me the app
, app-shm
, app-wal
files. The app does not gather any personal info, so you can send these without worries. You could attach them here, or you can send me the files via email (ammar.githam@outlook.com). This will allow me to run SQL queries directly on your db.
The app
db has indeed 3789
records in the favorites
table. The max id
is 3915
, so it seems I also removed quite a bunch. I don't remember setting this many 'favorites'.
Do you have auto 'mark as favorite' enabled in Auto wallpaper preferences?
No, all manual. I never had that setting active.
I see. 4k seems like a very big number to be manual. Have you ever previously done a backup/restore before?
No, I haven't. As I said, I can imagine marking quite a bunch because I used it less for 'favorite' and more for 'these are a pool of darker wallpapers'.
Is it possible for you to share the db?
Otherwise can you check if the following query returns anything:
SELECT source_id FROM favorites WHERE source_id IN
(SELECT source_id FROM favorites GROUP BY source_id HAVING COUNT(*) > 1);
Ideally it should not return anything.
I thought I did, but apparently I forgot to click on send while looking into the DB myself.
Thanks. I'll look into it. Btw, the crash is a SQLite limitation which Google's AndroidX Room library should've handled. But the issue is still open (https://issuetracker.google.com/issues/73634057).
Fixed in v2.4.2
I'm sorry this required so much code changes :(
The (normal version v2.4.1) app is crashing when trying to perform a backup.
Sorry, it seems I'm somehow good at finding these bugs… I have never backed up before. I want to test the plus version and bring settings, favorites, … over.
Repro: