G0-merge pass ranges by reference to array_ops methods

ammarhakim / gkyl

This is the main source repo for the Gkeyll 2.0 code. Please see gkeyll.rtfd.io for details.

https://gkeyll.readthedocs.io/en/latest/

54 stars 14 forks source link

G0-merge pass ranges by reference to array_ops methods #136

Closed akashukla closed 9 months ago

akashukla commented 9 months ago

Change function signatures in DataStruct/ZeroArry to match g0 which now passes ranges by reference instead of value. This is specifically to avoid "NYI" errors which appear on perlmutter and stellar when running on cpu. Selected g2 regression tests which use these functions pass on GPU and CPU: gk-sheath and vm-sheath. Goes with gkylzero Pr #206.

manauref commented 9 months ago

by "selected regression tests" do you mean they pass? on CPU and/or GPU? please use clear language