Closed manauref closed 2 years ago
This looks great Mana! I think this can be merged without issue. Two things I want to make a note of here for our own future records. These are only notes for record-keeping that your commit made me think about. No action is required.
@JunoRavin
Performed some serious simplifications in the Vlasov and GK apps, primarily to
Also wrap the array/CartField offset methods from g0. Note that 1. above will have to be re-examined when we re-implement the neutral model, because in that case not all species collide with each other. But the main point is that if species A collides with species B, we must have species B collide with species A, and that will still be true in neutral models.
Checked many regression tests on both CPU and GPU and they all look good.