search

ammarhakim / gkylzero

Lowest, compiled layer of Gkeyll infrastructure.
MIT License
22 stars 5 forks source link

Fix for reaction rates when using non-uniform velocity grids #470

Closed jRoeltgen closed 1 month ago

jRoeltgen commented 2 months ago

The reaction rate distribution function was not being scaled by the velocity space jacobian which is needed with non-uniform velocity grids. Note: (EDIT: Resolved: See comment below) Adding this fix does not result in a change in the resulting electron moments even though this would be expected with a quadratic velocity mapping, so there is likely a remaining bug I'm looking for.

jRoeltgen commented 2 months ago

The lack of change in the electron density when adding the scaling by the velocity jacobian is due to the reactions having a minor effect in the change in the electron density over the simulation time in rt_gk_li_react_3x2v_p1. Also the density changes by a very small amount ~10-4n0. In another test where the atomic reactions are dominant, a significant change in the electron density was observed.

manauref commented 2 months ago

thanks @jRoeltgen can you describe that other test or point to its input file? that might be a better regression test for reactions than this gk_li_react then, because this test clearly didn't help us identify a bug.

jRoeltgen commented 2 months ago

Added regression/rt_ar_react_1x2v_quadraticV.c as the test described in the prior comment.