ammarhakim / gkylzero

Lowest, compiled layer of Gkeyll infrastructure.
MIT License
22 stars 5 forks source link

Gk g0 app xptfinder bugfix #481

Closed akashukla closed 1 month ago

akashukla commented 1 month ago

Fixes issue #480: Serendipity basis is no longer used at all for Psi(R,Z) when using efit for geometry. Along with this we also fix a memory leak in efit.c. Also clean up some unit and regression tests, removing the rz_basis_type option for all of them.

(MF) Also fit some bugs:

  1. The case in which psi increases with x was not handled properly in efit.c, leading to a nonsensical flux grid.
  2. Redefined variables and variables with mixed scope were giving seg faults on Macs (but not Linux) even though the test was valgrind clean.