search

ammarsys / riot-password-changer

CLI application that automatically changes passwords for Riot games account
MIT License
7 stars 0 forks source link

What's the reason of this error？ #1

Closed RiotGamesPlayer closed 1 year ago

RiotGamesPlayer commented 1 year ago

image

RiotGamesPlayer commented 1 year ago

image

ammarsys commented 1 year ago

Hi, are you just running the script via the POKRENI_ME.bat? Can you provide the error in text format?

RiotGamesPlayer commented 1 year ago

I have solve the problems.because the chrome didn't work，so i re-downloaded the right vision of Chromedrive matched the vision of chrome exe，and after Reset computer，that's solved.

RiotGamesPlayer commented 1 year ago

If it can be changed to the password I specified, I think it might be better.it will be changed to a random password now.

ammarsys commented 1 year ago

Awesome! Glad to hear it is working. It does seem to be an issue with Chrome version even on my machine, so I went ahead and updated requirements.txt to not download a specific version (i.e. download the latest one) and specified version_main=109 in Driver Initialization as per issue on undetected_chromedriver 1047.

As for the feature idea, you're welcome to open a PR that implements it :) I think that the best way to go about this is to edit the format in accounts.txt to allow a second : which would indicate the desired user password. This would then be parsed in main.py and the Line 44 could be edited to look like:

new_password = desired_password or gen_sec_pass()

This would allow for desired_password to fall back to randomly generated password if the user did not provide it i.e. the variable is none.

RiotGamesPlayer commented 1 year ago

To be honest，i am a fresh，so i don't know how to make it.but i will have a try.

ammarsys commented 1 year ago

Awesome! Let me know if you decide to do it.

ammarsys commented 1 year ago

I will close this issue and open up a new one specifically for the feature request.