ammgws / ammcon-frontend

Frontend for AmmCon home automation project
Other
1 stars 0 forks source link

White line at top of profile #13

Closed WnndGws closed 7 years ago

WnndGws commented 7 years ago

When I am logged into ammcon, when i click the hamburger to bring out the slider, at the top of the site there is a tiny white border. It drives me insane. Pls correct asap 2017-03-03-16 42 40

ammgws commented 7 years ago

Result of your #14 PR

image

NARP.

WnndGws commented 7 years ago

Oh shucks

On Sat, Mar 4, 2017, 11:26 Juan notifications@github.com wrote:

Result of your #14 https://github.com/ammgws/ammcon-frontend/pull/14 PR

[image: image] https://cloud.githubusercontent.com/assets/20397027/23575746/ceeb1e7c-00d5-11e7-909c-b060bebb3303.png

NARP.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ammgws/ammcon-frontend/issues/13#issuecomment-284123644, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ5jORFLJf3UTcfPBFDG4Pd1DzvDUZFlks5riNnwgaJpZM4MSAAS .

ammgws commented 7 years ago

Looks like the culprit is the CSS to do with this element (the most outer element for the side panel): <div data-role="panel" id="leftpanel" data-display="overlay" data-position-fixed="true">

When page is loaded and panel is opened it has the following classes added to it, so have to look through them and see if there's anything there: <div data-role="panel" id="leftpanel" data-display="overlay" data-position-fixed="true" class="ui-panel ui-panel-position-left ui-panel-display-overlay ui-body-inherit ui-panel-fixed ui-panel-animate ui-panel-open">

ammgws commented 7 years ago

Jquery mobile example with no white line: <div data-role="panel" id="defaultpanel" data-theme="b">

<div data-role="panel" id="defaultpanel" data-theme="b" class="ui-panel ui-panel-position-left ui-panel-display-reveal ui-body-b ui-panel-animate ui-panel-open">

ammgws commented 7 years ago

Finally found it.

This CSS from nativedroid2.css setting top to 1px.:

.ui-panel-position-left > .ui-panel-inner {
    position: absolute;
    top: 1px;
    left: 0;
    right: 0;
    bottom: 0px;
    overflow: auto;
    -webkit-overflow-scrolling: touch;
}

Override it in ammcon.css:

.ui-panel-position-left > .ui-panel-inner {
    top: 0px;
}