ammmir / node-oauth2-provider

A simple customizable OAuth 2.0 provider (server) for node.js.
MIT License
628 stars 161 forks source link

Pass `grant_date` to `access_token` callback? #5

Closed yhahn closed 12 years ago

yhahn commented 12 years ago

Thanks for your work on this!

Small thing -- it looks like the grant_date has been encoded in the access_token so that implementers can expire or deny use of a given access token according to their needs. However, the grant_date is being parsed but not passed to the access_token callback here:

https://github.com/ammmir/node-oauth2-provider/blob/master/index.js#L53

I'm guessing this was just overlooked and needs a quick fix, but is there some other reason for withholding this from the callback?

ammmir commented 12 years ago

thanks for catching this omission!

to avoid breaking existing deployed code, i'll create a branch for v1 that you can track (i won't push it to npm for a while, though).

yhahn commented 12 years ago

Great, thank you.