search

ammuench / node-artifact-api

A node module wrapper for the Valve official Artifact API
MIT License
9 stars 4 forks source link

Cards Price on Steam Market #11

Open AonanLi opened 5 years ago

AonanLi commented 5 years ago

This request could return the current price of (first 100 out of 237) Artifact cards. It's not part of Valve Artifact API, but a nice to have.

Would be great if it the result json could be cached like cardsets, but expires after maybe 10mins.

I would like to contribute but I'm not that familiar with typescript. By the way how do you run/test your code locally?

ammuench commented 5 years ago

Typescript is just a superset of javascript--so if you just write in JS to start, It won't pass linting, but it'll run just fine and I could provide line-notes or convert accordingly myself.

The main thing is adding private/public declarations on class methods & declaring type/interfaces for returns, params, and random variables. Feel free to checkout this quick crash course if you'd like to take a crack at it.

To run tests, open a console and run npm run test, to run whatever code is in the demo.ts file, run npm run demo, and to run the linter run npm run lint