amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
11 stars 0 forks source link

Add a `transforms.to` within the `amnesty-core/collapsable` block to the `core/details` block #229

Closed jaymcp closed 3 days ago

jaymcp commented 1 month ago

Blocks with transforms.[to|from] options defined in their block registration call can be converted to/from the blocks set in these options. We should allow users to transform the deprecated amnesty-core/collapsable block to the newly re-enabled core/details block. (#228)

Reference: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-transforms/

Gentyspun commented 3 weeks ago

PR Created: https://github.com/amnestywebsite/humanity-theme/pull/241

AmnestyAM commented 3 days ago

should I expect to see the collapsible block here https://isaidotorgstg.wpengine.com/en/wp-admin/post.php?post=134079&action=edit be transformed into the details block

Image

jaymcp commented 3 days ago

The automatic transformation of the block has issues on DEV, so that hasn't been merged to STG yet: https://github.com/amnestywebsite/wp-plugin-amnesty-branding/pull/30, and is tracked by https://github.com/amnestywebsite/wp-plugin-amnesty-branding/issues/26.

The manual transformation (select collapsable -> transform -> details) should work, though, which is covered by this ticket.

AmnestyAM commented 3 days ago

LGTM Thanks