amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
35 stars 9 forks source link

Enhancement - Post List Block - Add background image support in list view mode #278

Closed AmnestyAM closed 3 weeks ago

AmnestyAM commented 3 months ago

Describe the bug
Post List Block - Object selection backend UI not loading

To Reproduce
Steps to reproduce the behavior:

  1. Create a post
  2. Add post list block
  3. choose object selection
  4. choose list view

Expected behaviour
A clear and concise description of what you expected to happen. image image

Gentyspun commented 2 months ago

PR Created: https://github.com/amnestywebsite/humanity-theme/pull/292

jaymcp commented 2 months ago

Marking this as an enhancement, as list view mode has never had background image support.

AmnestyAM commented 1 month ago

I think I messed up a little on this ticket, sorry!

It was the editor I had the issue with, as the editor showed the wrong UI that had the icons for adding images which it should not have had, this is now not an issue as I see the below for editing posts.

Image

I see we now render the featured image on the list block, which looks promising to me.

https://isaidotorgstg.wpengine.com/en/testing-278-images-on-post-list-view/

I think if we were to keep this style below...

Image

Then we would need the text too look like the below...

Image

@Khartzenberg @SophieAmnesty @carolinejcourtney @daveamnesty @jaymcp @Gentyspun what do you all think?

AmnestyAM commented 3 weeks ago

I think this can be closed, the object selection user interface is now showing on STG and PRD (it was not showing previously (I think)) so my guess is I either miss tested and reported a false bug, or the issue self resolved.

The way the text renders in the front end would not be approvable as it is, so I think its easier just to close this one and not release anything related to this ticket, what do you think @jaymcp ?

AmnestyAM commented 3 weeks ago

Also no one replied so I dont think anyone is fussed either way

jaymcp commented 3 weeks ago

I'm happy to go with whatever you prefer, @AmnestyAM, just let me know.

AmnestyAM commented 3 weeks ago

closing no longer required, thanks, and sorry for the confusing ticket

jaymcp commented 3 weeks ago

no worries, @AmnestyAM!