Migrate custom card custom block to custom card pattern

[AmnestyAM]

https://wordpresstheme.amnesty.org/blocks/b014-action/

• Group
• grey background
• heading
• image
• paragraph
• button

[Gentyspun]

Theme PR: https://github.com/amnestywebsite/humanity-theme/pull/309 Plugin PR: https://github.com/amnestywebsite/wp-plugin-amnesty-branding/pull/41

[AmnestyAM]

The caption looks weird, might need to flag this in training

Also the alignment control dont seem to do anything, might also be another training thing, unless you have thoughts @Gentyspun or @jaymcp

[AmnestyAM]

also what are you thoughts about the width? I was kind of expecting it to fill the horizontal space and then be constrained by the column it was in, but looks like we have a max width, I am not opposed to this just wanted your thoughts? Will this approach work well for this pattern being added into our sidebar and or 1/3 or 1/4 layouts?

Alignment, in the CMS it looks centered in the CMS when alignment is set to none, in the front end the card is bigger 480px wide and left aligned.

Alignment, in the CMS is left aligned in the CMS when set to 1468 in the CMS. The card is smaller in the front end at 350px.

Let me know your thoughts.

[AmnestyAM]

PS I might still pass this as its probably not blocking, just wanted your thoughts too

[AmnestyAM]

one other thing...

I still see the option to add the Custom Card Custom block (as well as the pattern).

I also don't see the custom block converting to the pattern here -> https://isaidotorgstg.wpengine.com/en/wp-admin/post.php?post=211890&action=edit

[Gentyspun]

Hey @AmnestyAM

I have a few notes/questions about your comments.

The image caption is just an issue with padding so I can fix that easily just adding padding to either side of the caption.

In regards to alignment, currently there is no alignment options only width (Normal and Wide), which is in line with how the block used to work. I'm happy to change this, but just wanted to clarify what you think is best for the pattern. So here are a couple of options:

• Remove the wide/normal option and have the block just fill whatever container it is inside, and then add left, centre, right alignment options
• Keep the wide/normal options and add alignment options as well, but this will mean the pattern will not automatically fill whatever container it is in.

Currently the normal and wide options just work with a max-width on the group I believe.

[AmnestyAM]

I think to fill the space is better then have someone use columns. We will tell people not to add a card in a page or post without columns, it should be used in columns or in a sidebar.

Thanks,

[Gentyspun]

I think to fill the space is better then have someone use columns. We will tell people not to add a card in a page or post without columns, it should be used in columns or in a sidebar.

Thanks,

PRs for custom card to fill it's container Theme: https://github.com/amnestywebsite/humanity-theme/pull/475 Branding Plugin: https://github.com/amnestywebsite/wp-plugin-amnesty-branding/pull/53