amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
18 stars 9 forks source link

Bug - Wrong Hebrew font showing #293

Open SophieAmnesty opened 1 month ago

SophieAmnesty commented 1 month ago

Message from user at amnesty.org.il:

I am writing you since I've noticed that lately something went wrong with our website fonts: all the blocks that aren't Paragraph appearing to have different and weird fonts all of a sudden:

hebrew font

I took a screenshot from one of our latest publications on the website, I've marked the "normal" font with green and the wrong one with red. Here is a link for one of the examples, but be aware that the change in fonts was affecting all the publications on our website, so it's pretty urgent for us to fix it. You will notice that basically any word that isn't just in Paragraph block, the font is odd: quote block, hyperlinks, subheaders, call for action etc.

Will appreciate your fast help,

SophieAmnesty commented 1 month ago

In some instances the wrong font is being triggered by bold font being applied where it doesn't need to be (e.g. headings). So there is a workaround to remove the bold formatting. This won't work everywhere thought (e.g. blockquote).

jaymcp commented 1 month ago

Hey @SophieAmnesty

Sorry about this. It's a regression from our migration to the new font loading methodology that's brought in by Full Site Editing. I hadn't correctly accounted for sites using our old font overloading functionality. I've built a new plugin that re-introduces this in a way that's compatible with FSE, and have deployed it to the staging site for this section.

Could you take a look and let me know what you think?

Thanks! Jay

SophieAmnesty commented 1 month ago

Thank you Jay!!

I've added this post to test it on staging: https://secisraelstg.wpengine.com/2024/07/15/3803/

The link looks EXTRA bold now:

image

should be like this I think:

image

But maybe this is a different issue?

Font looks right but the weight doesn't look quite right.

Do you see what I mean? thanks :)

jaymcp commented 1 month ago

Hey @SophieAmnesty, thanks for taking a look! I'm seeing something different to what you are, which is strange! This is how it looks for me on your test post:

SophieAmnesty commented 3 weeks ago

Hey @jaymcp - I just showed the user how to manually strip the formatting to avoid this issue, so we have a temporary workaround for now.

I'm still getting the super bold on the dev site test page:

image

I'm using Edge.

Is there anything else I can do to help with this one?

AmnestyAM commented 2 weeks ago

LGTM

jaymcp commented 2 weeks ago

@SophieAmnesty

I just showed the user how to manually strip the formatting to avoid this issue, so we have a temporary workaround for now.

Ah that would explain why I couldn't see the isue

I'm still getting the super bold on the dev site test page [image] I'm using Edge

Which dev site are you referring to, sorry? I have Edge installed, so can try to replicate on there.

SophieAmnesty commented 2 weeks ago

Sorry @jaymcp I think I meant staging. This link you shared: https://secisraelstg.wpengine.com/2024/07/15/3803/

jaymcp commented 2 weeks ago

Thanks @SophieAmnesty. I'm afraid I can't replicate on STG in Edge on Mac:

I will boot up a Windows VM to see if I can replicate there.

jaymcp commented 2 weeks ago

This is very strange. I can't reproduce in a Windows VM either:

SophieAmnesty commented 2 weeks ago

no worries! I showed Noam and he said it was preferable to the buggy font so yeah maybe we can just go ahead with the fix we have. thanks!

AmnestyAM commented 1 week ago

PS I uploaded the front plugin to Eurasia and .il