search

amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
38 stars 10 forks source link

On the join block modal review accessibility #30

Open jaymcp opened 1 year ago

jaymcp commented 1 year ago

Describe the bug
On the join block modal review accessibility

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.amnesty.org/en/get-involved/join/
  2. Tab to Join Now
  3. See focus

Expected behaviour
We should trap the focus within the modal when activated via keyboard or screen reader

Actual behaviour
The join modal is lacking in accessibility support. Specifically, it doesn't trap focus within the modal when activated via keyboard or screen reader.

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/en/get-involved/join/

Screenshots
image

Gentyspun commented 1 month ago

PR Created: https://github.com/amnestywebsite/wp-plugin-theme-companion/pull/61