search

amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
23 stars 9 forks source link

On the Social icons block the styling has changed and is no longer on brand #36

Open AmnestyAM opened 11 months ago

AmnestyAM commented 11 months ago

Describe the bug
On the Social icons block the styling has changed and is no longer on brand

To Reproduce
Steps to reproduce the behavior:

  1. Add a page
  2. Add social icons
  3. We dont have a screen shot :-(
  4. https://web.archive.org/web/20200222173941/https://www.amnesty.org/en/get-involved/

Expected behaviour
They should have padding and use the theme default not WP animation animations

Actual behaviour
we lost our styles

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/en/get-involved/

Screenshots
https://web.archive.org/web/20200222173941/https://www.amnesty.org/en/get-involved/ https://wordpresstheme.amnesty.org/blocks/b018-social-icons/

jaymcp commented 11 months ago

it appears that core have updated the CSS classes they use for that block. so it's a regression, but probably more because of a core update than a theme change

Gentyspun commented 6 months ago

Created a PR on the theme to remove the branding block styles and a PR on the branding plugin to add them back in. Theme PR fixes margin and transform styles from original ticket.

Theme PR: https://github.com/amnestywebsite/humanity-theme/pull/97 Plugin PR: https://github.com/amnestywebsite/wp-plugin-amnesty-branding/pull/7

AmnestyAM commented 2 months ago

Looks like the buttons moved position was that expected?

Image

https://www.amnesty.org/en/get-involved/ https://isaidotorgstg.wpengine.com/en/get-involved/

jaymcp commented 2 months ago

Ah, looks like the wrapper is missing the alignment attribute FYI @Gentyspun

AmnestyAM commented 5 days ago

LGTM on STG also LGTM on PRD which is a little strange but fine.