amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
37 stars 9 forks source link

Investigate — WP 6.6 Compatibility #365

Closed jaymcp closed 6 days ago

jaymcp commented 2 months ago

Exploratory ticket for discovering issues introduced by upgrading our supported WP version from 6.4. to 6.6..

Issues found:

jaymcp commented 2 months ago

php templates are no longer selectable in the block editor

this appears to be an intentional change in WP 6.5, and there doesn't appear to be a solution. workaround is to use quick edit to select a template. this is terrible ux for editorial, so it increases the priority of #246

correction: although the template is selectable in quick edit, it no longer saves as anything other than default. we'd have to manually set it in SQL

jaymcp commented 2 months ago

superfluous padding on the frontend. Can be fixed by removing styles.spacing.padding from theme.json. Removing this, however, results in a lack of padding in the block editor.

solution: keep padding in theme.json, and overwrite it on the frontend with css, as that's easier than overwriting editor styles.

jaymcp commented 2 months ago

shop front has some issues (products not loading)

as per my above comment, we need to set the shop page template back via SQL, thanks to WP deciding to no longer support classic/hybrid theme php templates in 6.5

update wp_postmeta set meta_value = 'templates/shop-index.php' where meta_key = '_wp_page_template' and post_id = [id]
jaymcp commented 1 month ago

Issues found:

  • superfluous padding on the frontend. Can be fixed by removing styles.spacing.padding from theme.json. Removing this, however, results in a lack of padding in the block editor.

This is fixed in core in WP 6.6.2 https://core.trac.wordpress.org/ticket/61704