search

amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
38 stars 10 forks source link

Remove superfluous padding from the body tag #388

Closed jaymcp closed 2 months ago

jaymcp commented 2 months ago

The padding originates from theme.json. We can't however remove it without leaving the block editor with no spacing between the side panels and the content area. Rather than provide a worse editorial experience, we just override it on the frontend in CSS.

Ref: https://github.com/amnestywebsite/humanity-theme/issues/365

Steps to test:

  1. view the frontend
  2. there should no longer be whitespace between the footer and the margins on the horizontal axis
  3. edit a post in the block editor
  4. there should be whitespace between the admin menu and the blocks in the post
  5. edit a template in the site editor
  6. there should be whitespace between the sidebar and the blocks in the template
jaymcp commented 2 months ago

This is actually fixed in core in 6.6.2, which was released yesterday: https://core.trac.wordpress.org/ticket/61704 Since this PR is part of the work towards #365, we can close this PR without merging.