search

amnestywebsite / humanity-theme

The Amnesty International WordPress Humanity Theme
https://wordpresstheme.amnesty.org/
Other
38 stars 10 forks source link

Bug - v2.0.0 - Old skip link visible on location template(s) #437

Closed jaymcp closed 1 month ago

jaymcp commented 1 month ago

Related to https://github.com/amnestywebsite/humanity-theme/issues/246

Describe the bug
The skip link that was removed in https://github.com/amnestywebsite/humanity-theme/issues/345, in favour of WP core's, is still visible without styling on location templates

To Reproduce
Steps to reproduce the behaviour:

  1. Checkout the v2.0.0 release branch: git checkout release/v2.0.0
  2. Run a build: cd private && yarn build
  3. Visit a location page
  4. See that the text Skip to main content is visible at the top left of the page

Expected behaviour
The custom skip link should no longer exist

Actual behaviour
The custom skip link is still in place, albeit with no styling

Screenshots
image (4)

jaymcp commented 1 month ago

Fixed in https://github.com/amnestywebsite/wp-plugin-amnesty-branding/commit/16d022d39e58b1b24a70a6137bbf766673bce629