search

amnezia-vpn / amnezia-client

Amnezia VPN Client (Desktop+Mobile)
https://amnezia.org
GNU General Public License v3.0
5.83k stars 365 forks source link

[Windows] Split Tunneling: uploading relatively big site list causes memory leak #1219

Open Rebel028 opened 3 weeks ago

Rebel028 commented 3 weeks ago

Describe the bug Uploading relatively big site list causes memory leak. After restarting the app it's impossible to reset the list because it requires to load the whole list into the UI (that causes memory leak again). Mentioned in https://github.com/amnezia-vpn/amnezia-client/issues/1135 but was not solved

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings'->'Connection'->'Site-based split tunneling'
  2. Click on three dots then 'import'
  3. Choose file for import: amnezia_sites.json (this file is very big but you can reproduce in with file from https://github.com/amnezia-vpn/amnezia-client/issues/1135)
  4. Application starts consuming RAM like crazy

Expected behavior List is loaded successfully and app is usable

Log files Logs are enabled in settings, but no logs are written

Desktop (please complete the following information):

Additional context

Related issues:

It probably has something to do with client/ui/controllers/sitesController.cpp and I would gladly fixed it myself if I'd ever worked with Qt and C++

Xambey commented 2 weeks ago

plus one