search

amnezia-vpn / amnezia-client

Amnezia VPN Client (Desktop+Mobile)
https://amnezia.org
GNU General Public License v3.0
5.79k stars 360 forks source link

Invalid error handling of non-existent container #450

Closed useribs closed 10 months ago

useribs commented 11 months ago

https://github.com/amnezia-vpn/amnezia-client/blob/08c506a48933e46eaeb105a2b3ae52237c547cd5/client/core/servercontroller.cpp#L166C28-L166C28

it expects "Error: No such container:"

I am not familiar with C, but this error message handling seems wrong, on my system i get the following error when trying to deal with non-existent container:

Error response from daemon: No such container: blad

# docker -v
Docker version 24.0.7, build afdd53b

Proposed fix: expect only No such container: without Error string.

useribs commented 10 months ago

Should be fixed #by: https://github.com/amnezia-vpn/amnezia-client/pull/482

useribs commented 10 months ago

fix made it into dev?

lunardunno commented 10 months ago

yes.