search

amnezia-vpn / amneziawg-linux-kernel-module

AmneziaWG Linux kernel module
https://www.wireguard.com
GNU General Public License v2.0
80 stars 17 forks source link

Improve debian installation instructions #27

Closed marek22k closed 1 month ago

marek22k commented 2 months ago

see https://github.com/amnezia-vpn/amneziawg-go/issues/44#issuecomment-2365364001

leninalive commented 1 month ago

@marek22k software-properties-common isn't a GUI package, but a package that contains add-apt-repository script for older Ubuntu/Debian distributions.

Regarding key IDs/fingerprints and other details please keep in mind that this README is proposed mostly for end users who doubtly will want to know all of them, but excessive details may appear to them too aggressive. Professional users like you could always go to our Launchpad repository and find everything there.

And finally our Launchpad details will probably change soon as we erroneously created personal account instead of a Team one there so your recommendations will soon become outdated.

Due to all of this, I unfortunately have to reject your PR.

marek22k commented 1 month ago

@marek22k software-properties-common isn't a GUI package, but a package that contains add-apt-repository script for older Ubuntu/Debian distributions.

But do my or your instructions use this tool at all?

Regarding key IDs/fingerprints and other details please keep in mind that this README is proposed mostly for end users who doubtly will want to know all of them, but excessive details may appear to them too aggressive. Professional users like you could always go to our Launchpad repository and find everything there.

Every manual for Debian packages mentions its fingerprint, otherwise it could lead to MitM attacks. Furthermore, it is obsolete and no longer recommended to add keys from individual repos to the APT keyring. You should use signed-by instead.

And finally our Launchpad details will probably change soon as we erroneously created personal account instead of a Team one there so your recommendations will soon become outdated.

These changes could simply be adopted in a change to the README.

Due to all of this, I unfortunately have to reject your PR.

I have to admit that I see it differently. My guide clearly uses more modern methods and is just as easy copy-and-paste (even if you don't understand the commands) as the previous one.