search

amnh-library / API-Portal

AMNH Library API
http://api-dev.library.amnh.org/api/v1/people
5 stars 0 forks source link

Troubleshoot Elasticsearch and Node.js errors #2

Closed mik3caprio closed 7 years ago

mik3caprio commented 7 years ago

Elasticsearch is complaining about a syntax error in a search that was requested of it (pdelong42).

mik3caprio commented 7 years ago

Mar 23 16:16:27 lbry-web-005.amnh.org npm[2766]: (node:2776) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 77): TypeError: Cannot read property 'map' of undefined Mar 23 16:10:02 lbry-web-005.amnh.org npm[2766]: GET /api/v1/resources/archives-space?q=chapman - - ms - - Mar 23 16:16:27 lbry-web-005.amnh.org npm[2766]: (node:2776) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 77): TypeError: Cannot read property 'map' of undefined

mik3caprio commented 7 years ago

I believe this problem is still occurring as I am not seeing results for people API endpoint details when calling the API with a xeac ID number

mik3caprio commented 7 years ago

Myself and @pdelong42 took a look at ElasticSearch today and determined that properly formed queries can be received by ElasticSearch and return results, and that there do not seem to be firewall or port related issues. So it's likely code related, maybe something to do with not error checking for null results in some portion of it?

@recursion-ninja would you like to take a look at the code here in /routes/API_V1.js? Maybe we could converse a bit over Slack, or do a screen share with me over my VPN access some time to try a little debugging?

mik3caprio commented 7 years ago

This issue is primarily due to the ArchivesSpace portion of the API, which appears to not function properly. It has been commented out for now, and developing a functional ArchivesSpace integration will become an issue in the other project for feature development.