search

amnh / PCG

𝙋𝙝𝙮𝙡𝙤𝙜𝙚𝙣𝙚𝙩𝙞𝙘 𝘾𝙤𝙢𝙥𝙤𝙣𝙚𝙣𝙩 𝙂𝙧𝙖𝙥𝙝 ⸺ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Refactor out the "Data Unification" modules into a sub library #114

Closed recursion-ninja closed 5 years ago

recursion-ninja commented 5 years ago

The data unification module is a bit of a disaster currently. The module alone is in need of some refactoring to make the complex logic more comprehensible.

However, while refactoring the module itself, we can also separate out this logic from the PCG.Command.Read.Unification module and into it's own pcg-data-unification sub library which will depend on pcg-data-normalization and the core data structures library which contains the Bio module.

This separation into a sub library will make the unification logic more accessible for unit and integration testing, allowing for Arbitrary instances to create unified objects.

recursion-ninja commented 5 years ago

This has been completed. See this commit d7000ec