search

amnh / PCG

𝙋𝙝𝙮𝙡𝙤𝙜𝙚𝙣𝙚𝙩𝙞𝙘 𝘾𝙤𝙢𝙥𝙤𝙣𝙚𝙣𝙩 𝙂𝙧𝙖𝙥𝙝 ⸺ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Place Test.Custom.DynamicCharacterNode in a testing utilities library #125

Closed recursion-ninja closed 5 years ago

recursion-ninja commented 5 years ago

Perhaps the Test module should be moved out of the pcg-utility library to a pcg-testing library and the Test.Custom.DynamicCharacterNode should be placed there along with Arbitrary input generation.

Alternatively, it could be embedded in the executable's source files that need this code.

recursion-ninja commented 5 years ago

The threeway-mean-check would perform the direct optimization preorder logic on the root node of randomly generated cherry trees. All it did was print the inputs if an exception was thrown while doing this work. I removed the threeway-mean-check executable as it no longer provided meaningful utility to PCG, this code hasn't thrown exceptions in about a year. It was the only module which depended on Test.Custom.DynamicCharacterNode which was a very fragile module, breaking whenever any core type changed slightly. Removing these is much easier than maintaining them for no reason.

See this commit 9e1f55d.