amnh / PCG

๐™‹๐™๐™ฎ๐™ก๐™ค๐™œ๐™š๐™ฃ๐™š๐™ฉ๐™ž๐™˜ ๐˜พ๐™ค๐™ข๐™ฅ๐™ค๐™ฃ๐™š๐™ฃ๐™ฉ ๐™‚๐™ง๐™–๐™ฅ๐™ โธบ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Upgrade to GHC-8.8.1 #146

Closed recursion-ninja closed 5 years ago

recursion-ninja commented 5 years ago

These dependencies are currently stopping our upgrade:

recursion-ninja commented 5 years ago

Cabal still isn't building with ghc-8.8.1 because of cassava, our barely used CSV rendering dependency.

I think it's because cabal-3.0 handles the packages flags slightly differently, and cassava uses a lot of cabal build flags to decide which bytestring library to use.

recursion-ninja commented 5 years ago

@Boarders can you look into why cabal-3.0 and cassava aren't working together? I'm stumped.

Maybe we can make a cabal.freeze file to fix some dependencies and force cassava to not fail?

recursion-ninja commented 5 years ago

Let's drop the cassava dependency and use unlines . fmap (intercalate ",").

wardwheeler commented 5 years ago

Thereโ€™s a solution

recursion-ninja commented 5 years ago

We removed the cassava dependency from our project. See 75222d520f6c1031632d5d83b423602cca04f55a.

Our project now builds with ghc-8.8.1 on both cabal-3.0 and stack. We can consider merging the ghc-8.8.1 branch into master in the near future.

Boarders commented 5 years ago

Excellent to hear!

wardwheeler commented 5 years ago

Nice

recursion-ninja commented 5 years ago

master is compiling ghc-8.8.1. See a9c71f97e1d5e4a07dae6741897b5481488b9277.