amnh / PCG

𝙋𝙝𝙮𝙡𝙤𝙜𝙚𝙣𝙚𝙩𝙞𝙘 𝘾𝙤𝙢𝙥𝙤𝙣𝙚𝙣𝙩 𝙂𝙧𝙖𝙥𝙝 ⸺ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Add validation check to Read command #152

Open Boarders opened 5 years ago

Boarders commented 5 years ago

When we read a graph we may be given a consensus graph in which nodes can have both multiple parents and multiple children. When we convert this graph into our internal format there are several approaches we might take:

When reading a graph we should start by trying to do the first approach (i.e. pick some binary tree amongst the space of consensus trees represented by the graph). We should then check that this tree is valid. If this is not valid we should then take our consensus binary network and delete network edges until it becomes temporally valid (this will happen eventually as we eventually end up with one of the display trees). Whichever tree we eventually use for the search should be logged to a file so the user can compare this against the input tree.

In the case that we begin deleting network edges we should consider asking the user for input on whether to continue the search (perhaps with some default yes option available).