Closed Boarders closed 4 years ago
Can't sort all alphabets.
Alphabets of "additive characters" must remain in their input order (likely unsorted). Otherwise the additive TCMs would be transformed from a useful structure to a rather useless one, and the character would then have to be treated as a "metric character."
Ok, I have a fix for the unsorted code so I will merge that.
Currently on master several of the tests to do with dynamic character decoding fail (with some throwing exceptions). I eventually tracked down that this is an error in the unsorted branch of the
getSubsetIndex
code. In particular I added the following test:This gives the following:
For now I am going to fix the error in the unsorted function but it is probably worth moving towards having an invariant that all alphabets are always sorted and deleting code that doesn't assume otherwise.
I should note that using only sorted alphabets fixes all the tests from
core:data-structures
to pass.