amnh / PCG

𝙋𝙝𝙮𝙡𝙤𝙜𝙚𝙣𝙚𝙩𝙞𝙘 𝘾𝙤𝙢𝙥𝙤𝙣𝙚𝙣𝙩 𝙂𝙧𝙖𝙥𝙝 ⸺ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Add "single-assignment" field to dynamic characters #55

Closed recursion-ninja closed 6 years ago

recursion-ninja commented 7 years ago

We need this field for the 3D direct optimization to converge efficiently. Possibly also required for implied alignments.

This field goes on the pre-order decoration with the "final" assignments.

recursion-ninja commented 6 years ago

Added this. I think I derived the values correctly... maybe.

wardwheeler commented 6 years ago

Your confidence inspires

Sent from mobile

On Dec 8, 2017, at 10:12 PM, recursion-ninja notifications@github.com<mailto:notifications@github.com> wrote:

Added this. I think I derived the values correctly... maybe.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famnh%2FPCG%2Fissues%2F55%23issuecomment-350419632&data=01%7C01%7Cwheeler%40amnh.org%7Cf7dc85b587a1421394fb08d53eb2acbc%7Cbe0003e8c6b9496883aeb34586974b76%7C0&sdata=PmUoGMfqpp7qbryyZZze6dW4ej56oiG1R4fUKHS82gA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFIM5JyUnScMwdH5GaacUDIj2ezW1aFlks5s-fqZgaJpZM4Pgw8b&data=01%7C01%7Cwheeler%40amnh.org%7Cf7dc85b587a1421394fb08d53eb2acbc%7Cbe0003e8c6b9496883aeb34586974b76%7C0&sdata=0LiyicQcCMxaoX%2FSVy7AaMLuGgbJ2u2xdFI0Om40L1c%3D&reserved=0.

recursion-ninja commented 6 years ago

It's not correct.

recursion-ninja commented 6 years ago

I corrected this. It was related to the BitVector type being big-endian rather than the more sensible little-endian representation.