search

amnh / PCG

𝙋𝙝𝙮𝙡𝙤𝙜𝙚𝙣𝙚𝙩𝙞𝙘 𝘾𝙤𝙢𝙥𝙤𝙣𝙚𝙣𝙩 𝙂𝙧𝙖𝙥𝙝 ⸺ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Add "missing" Character Blocks in Character Sequence #61

Closed recursion-ninja closed 6 years ago

recursion-ninja commented 7 years ago

There are cases on the pre-order traversal where a character block may not be present on a given node. We need to alter the CharacterSequence data structure to support representing this.

recursion-ninja commented 6 years ago

A decent name for this might be "Does Not Exist." The name "Missing" has other meaning for characters in our codebase, the name "Inapplicable" has other biological meaning.

recursion-ninja commented 6 years ago

This is implemented, but I am unsure if it is used. I believe (intuitively) that networks that contain character blocks that do not exist, will have infinite cost and a preorder traversal should never be performed.

Regardless, this is implemented. If it is never used, we can remove it later.