Closed recursion-ninja closed 6 years ago
recursion-ninja
commented
6 years ago This is close to being done.
The Data.BitMatrix module should switch to depending on the little-endian BitVector version. Afterward the bv package can be removed from the dependency list.
recursion-ninja
commented
6 years ago On commit 81a6178, all the unit tests pass except one. I'll investigate the failure later then merge into master.
recursion-ninja
commented
6 years ago This is finally finished.
All the test-suites are passing. Bit matrix, dynamic character, and static character test suites which (transitively) depend on the new BitVector type have been expanded for more complete coverage.
wardwheeler
commented
6 years ago Great commit W
Sent from mobile
On Jan 4, 2018, at 11:55 AM, recursion-ninja notifications@github.com<mailto:notifications@github.com> wrote:
This is finally finished.
All the test-suites are passing. Bit matrix, dynamic character, and static character test suites which (transitively) depend on the new BitVector type have been expanded for more complete coverage.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famnh%2FPCG%2Fissues%2F62%23issuecomment-355336458&data=01%7C01%7Cwheeler%40amnh.org%7C5161c096583d460e135e08d55393fff9%7Cbe0003e8c6b9496883aeb34586974b76%7C0&sdata=%2FABkQXqxGlRrR%2BJSU75gL2XausOns1qpORgZjrfhncc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFIM5HRctRsMhmNOrElXIOweBI6zDyUeks5tHQKRgaJpZM4Q7QzT&data=01%7C01%7Cwheeler%40amnh.org%7C5161c096583d460e135e08d55393fff9%7Cbe0003e8c6b9496883aeb34586974b76%7C0&sdata=H4ZFPTGSRuep0dQBTdl3jzIrVrlvPItfvfpSE4LHWsk%3D&reserved=0.
ima-hima
commented
6 years ago Yeah, no kidding.
On 2018, January 4 at 11:56:38, Ward Wheeler (notifications@github.com) wrote:
Great commit W
Sent from mobile
On Jan 4, 2018, at 11:55 AM, recursion-ninja notifications@github.com<mailto:notifications@github.com> wrote:
This is finally finished.
All the test-suites are passing. Bit matrix, dynamic character, and static character test suites which (transitively) depend on the new BitVector type have been expanded for more complete coverage.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famnh%2FPCG%2Fissues%2F62%23issuecomment-355336458&data=01%7C01%7Cwheeler%40amnh.org%7C5161c096583d460e135e08d55393fff9%7Cbe0003e8c6b9496883aeb34586974b76%7C0&sdata=%2FABkQXqxGlRrR%2BJSU75gL2XausOns1qpORgZjrfhncc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFIM5HRctRsMhmNOrElXIOweBI6zDyUeks5tHQKRgaJpZM4Q7QzT&data=01%7C01%7Cwheeler%40amnh.org%7C5161c096583d460e135e08d55393fff9%7Cbe0003e8c6b9496883aeb34586974b76%7C0&sdata=H4ZFPTGSRuep0dQBTdl3jzIrVrlvPItfvfpSE4LHWsk%3D&reserved=0. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
The current BitVector library uses a big-endian representation which makes all the vectors backwards in Semigroup definitions and to/from bits operation.
We should use our own little-endian representation to resolve subtle defects infiltrating our code.
Requires a very robust test suite for QA assurances.