Merging existing pull requests

amnong / easywebdav

A WebDAV Client in Python

http://pypi.python.org/pypi/easywebdav/

ISC License

207 stars 113 forks source link

Merging existing pull requests #18

Closed kartoch closed 10 years ago

kartoch commented 10 years ago

I have merged non conflicting branch requests. Is there any way you can merge to the main repo and upload to pypy the new version ?

List of changes:

fix 405 on creating existing directory
check if remote documents exists
create intermediate directory
support for python3
add an option to not verify ssl certificate
provide file access to the file
setting stream = True in request
add a path option for the webdav server
add content type

amnong commented 10 years ago

Hello Kartoch, Two questions, if you will:

Does this merge request contain all previous merge requests? You said "non conflicting merge requests" - have you left out any specific merge request? I'd like to pull your request and then remove all irrelevant requests.
After the adaptations to Python 3, does the code still run on Python 2.7, in all scenarios?

amnong commented 10 years ago

So after checking the changes I found and fixed two bugs. Due to this fact, I'm not really confident about releasing a new version to PyPI yet, but I'm going to commit the code (and my fixes) right now.

I will release a new version after I write some unit tests, I think I'm going to use PyWebDAV as the server as it seems really lite and easy to use.

kartoch commented 10 years ago

I've tried to merge most of the pending pull requests. The only ones not included are redundant, are changing too much the project organization or I'm not sure about them (especially the ones about write vs shutil.copyfileobj).

The problem of testing is the need for integration and unit tests. I would propose for now to tag my pull request as beta until it is well tested.

Please don't commit my last two commits.

amnong commented 10 years ago

Done. Closing this issue.