GUI misrepresents zero as "no value"

amnuts / opcache-gui

A clean, effective and responsive interface for Zend OPcache

1.21k stars 197 forks source link

GUI misrepresents zero as "no value" #16

Closed ToonSpinISAAC closed 7 years ago

ToonSpinISAAC commented 7 years ago

Certain OPcache settings, such as opcache.revalidate_freq, are integers for which can make sense if they equal zero. However, the OPcache GUI currently shows "no value" instead of "0" if the integer value is zero. This has caused us quite a bit of worry, thinking PHP ini settings weren't getting picked up, before we realized that the problem is in this application.

The problem is a JavaScript comparison that uses == instead of ===. I am making a pull request that fixes this issue.

amnuts commented 7 years ago

Thanks very much for the patch! :+1:

ToonSpinISAAC commented 7 years ago

No problem, thanks for merging!