search

amnuts / opcache-gui

A clean, effective and responsive interface for Zend OPcache
1.22k stars 198 forks source link

Switch dependencies to hosts who serve over HTTPS #2

Closed jkrehm closed 9 years ago

jkrehm commented 9 years ago

If the page is used in an application that's hosted over HTTPS, browsers throw fits about the JavaScript files getting loaded over HTTP. jquery.com doesn't have an HTTPS solution, and one wasn't obvious for fb.me, so I switched to two well-known hosts that do offer HTTPS.

I kept the version numbers the same.

amnuts commented 9 years ago

Thanks! I have been meaning to do that for a little while (I also use it on HTTPS at work) but kept forgetting. Jquery has hosting over HTTPS, though - https://code.jquery.com/jquery-2.1.3.min.js - and would probably prefer that used to googleapi.

jkrehm commented 9 years ago

Ah, I missed the announcement that jQuery has its own CDN now (not a new announcement - 2013 - but I've not looked into jQuery's hosting again because Google has worked all for me).

I'll update my pull request.

Jonathan Rehm On Jan 29, 2015 3:11 AM, "Andrew Collington" notifications@github.com wrote:

Thanks! I have been meaning to do that for a little while (I also use it on HTTPS at work) but kept forgetting. Jquery has hosting over HTTPS, though - https://code.jquery.com/jquery-2.1.3.min.js - and would probably prefer that used to googleapi.

— Reply to this email directly or view it on GitHub https://github.com/amnuts/opcache-gui/pull/2#issuecomment-71999964.

jkrehm commented 9 years ago

Updated to use jQuery's CDN instead of Google's.