search

amohanta / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 0 forks source link

Code Review: *jasvir/jsfunfuzz-original@1500 #317

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Description:

Added jsfunfuzz and hooks to call the parser using it to flush out
errors parsing.

Affected Paths:
   A //trunk/src/javatests/com/google/caja/parser/js/JsFunFuzz.java
   A //trunk/src/third_party/js/jsfunfuzz
   A //trunk/src/third_party/js/jsfunfuzz/about.txt
   A //trunk/src/third_party/js/jsfunfuzz/jsfunfuzz.html
   A //trunk/src/third_party/js/jsfunfuzz/jsfunfuzz.js
   A //trunk/src/third_party/js/jsfunfuzz/multi_timed_run.py
   A //trunk/src/third_party/js/jsfunfuzz/using.txt

Original issue reported on code.google.com by jas...@gmail.com on 27 May 2008 at 2:05

GoogleCodeExporter commented 9 years ago 
Note I had to make some changes to jsfunfuzz.js itself to make it work with 
Rhino.
Since this is third_party code, this is not great but I am not sure how else to 
do this.

Original comment by jas...@gmail.com on 27 May 2008 at 2:07

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 27 May 2008 at 3:06

GoogleCodeExporter commented 9 years ago 
changes/jasvir/jsfunfuzz/trunk/src/third_party/js/jsfunfuzz/about.txt@1465
Seems to be missing linebreaks

changes/jasvir/jsfunfuzz/trunk/src/third_party/js/jsfunfuzz/jsfunfuzz.js@1465
You mentioned changes.  If this has changes, can we check in the original 
first, and
then put the changes in as a separate CL?

changes/jasvir/jsfunfuzz/trunk/src/third_party/js/jsfunfuzz/multi_timed_run.py@1
465
From the python style guide:
    Although you may see this in a lot of current code, do not use #!/usr/bin/env
    python2.4. Due to a complex interaction between the kernel and killall,
    scripts using /usr/bin/env cannot be reliably killed via killall.

Original comment by mikesamuel@gmail.com on 27 May 2008 at 3:16

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 27 May 2008 at 4:27

GoogleCodeExporter commented 9 years ago 
* Split CL into jsfunfuzz-original and jsfunfuzz.
* The end-of-line character problems are from the original package - changed 
them in
jsfunfuzz CL
* The env call is from the original package - changed them in jsfunfuzz CL

Original comment by jas...@gmail.com on 30 May 2008 at 1:18

GoogleCodeExporter commented 9 years ago 
Please remove the svn:executable property from all these files.
    svn propdel svn:executable <files>
should do it.

Then the original stuff LGTM.  I'll review the new stuff after you've merged 
with the
original code.

Original comment by mikesamuel@gmail.com on 30 May 2008 at 3:30

GoogleCodeExporter commented 9 years ago

Original comment by jas...@gmail.com on 30 May 2008 at 5:35