search

amohanta / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 0 forks source link

Eclipse JUnit shows green when "ant runtests" doesn't. #657

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
On Mon, Jul 14, 2008 at 12:12 PM, <mikesamuel@gmail.com> wrote:
>     if (Array.slice === (void 0)) {
>      /** In anticipation of ES4, and because it's useful. */
>      Array.slice = function(self, start, end) {
>    -    return Array.prototype.slice.call(self, start, end);
>    +    return Array.prototype.slice.call(self, start || 0, end ||
self.length);
>      };
>     }

I introduced and committed the build-breaking version Mike Samuel just
repaired. The reason? I was checking whether I'm green by running the JUnit
tests from Eclipse. I just verified that without Mike's fix Eclise shows
green but "ant runtests" does not. With Mike's fix, they both run green. I
have no idea why. Until we do, please always verify your greenness with
"ant runtests" before committing to trunk.

Original issue reported on code.google.com by erights on 17 Jul 2008 at 2:16

GoogleCodeExporter commented 9 years ago 
We now have ant runtests in the presubmit checks for myvn commit.

The problem with eclipse is usually that it is not regenerating generated files 
under
ant-lib

Original comment by mikesamuel@gmail.com on 25 Sep 2009 at 8:19