search

amohanta / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 0 forks source link

Review ihab/domitafix@2037 #659

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Fix or test/verify Issue 447 and Issue 609, about handling of NAME
and TARGET attributes in HTML. Various attendant changes --

build.xml: Added copying of HTML to ease updating domita_test.html stuff.

html4-attributes-defs.json: Added a definition so NAME is by default suffixed
by the plugin ID suffix.

domita.js: Now adding suffix to NAME attributes. Also removed a line of
dead code.

html-sanitizer.js: Removed a piece of dead code.

HtmlCompilerTest.java: Added test for general NAME rewriting.

domita_test.[js,html]: Added tests for rewriting of NAME and TARGET attrs.

Original issue reported on code.google.com by ihab.a...@gmail.com on 23 Jul 2008 at 11:43

GoogleCodeExporter commented 9 years ago 
So this adds the id suffix to name?

Can we avoid putting non-standard attributes in html4-defs?
Maybe we should make the extensions the default schemas.

Original comment by mikesamuel@gmail.com on 25 Jul 2008 at 11:26

GoogleCodeExporter commented 9 years ago 
> So this adds the id suffix to name?

Yes.

> Can we avoid putting non-standard attributes in html4-defs?
> Maybe we should make the extensions the default schemas.

Done for both HTML and CSS per our discussion.

Re-snapshotted in r2037.

Original comment by ihab.a...@gmail.com on 28 Jul 2008 at 10:30

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 28 Jul 2008 at 10:32

GoogleCodeExporter commented 9 years ago 
LGTM

Original comment by mikesamuel@gmail.com on 29 Jul 2008 at 8:31

GoogleCodeExporter commented 9 years ago

Original comment by ihab.a...@gmail.com on 11 Aug 2008 at 9:33