search

amohanta / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 0 forks source link

Attack review: mikesamuel/bug-560 (101 added, 3 removed, 28 changed #675

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
gvn review mikesamuel/bug-560

*mikesamuel/bug-560@2112 | mikesamuel | 2008-08-06 19:03:50 -0800 (Wed, 06
Aug 2008)

Description:

Bug 560: tameNodeList gives access to a bare function
Bug 568: Domita: TameNodes need to consistently check editable

Made node list and item method frozen, changed item method to use
nodes instead of this.

Added editable___ checks to removeChild, appendChild, insertBefore.

Modified domita_test.js to test for failures in a way that doesn't
lead to spurious success and modified the styles so that failed tests
are visually obvious in the HTML page.

Affected Paths:
   M //trunk/src/com/google/caja/plugin/domita.js
   M //trunk/tests/com/google/caja/plugin/domita_test.html
   M //trunk/tests/com/google/caja/plugin/domita_test.js

Original issue reported on code.google.com by mikesamuel@gmail.com on 7 Aug 2008 at 3:11

GoogleCodeExporter commented 9 years ago 
LGTM

Original comment by jas...@gmail.com on 8 Aug 2008 at 12:47

GoogleCodeExporter commented 9 years ago

Original comment by jas...@gmail.com on 8 Aug 2008 at 12:47

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 9 Aug 2008 at 2:46

GoogleCodeExporter commented 9 years ago

Original comment by erights on 16 Sep 2008 at 7:27

GoogleCodeExporter commented 9 years ago 
Attack reviews are to be conducted pre-release.

Original comment by mikesamuel@gmail.com on 13 Jan 2009 at 8:13

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 13 Jan 2009 at 8:59