search

amohanta / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 0 forks source link

Code review: mikesamuel/regexp-div-ambiguity-fixes (29 added, 0 removed, 10 changed) #689

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
gvn review mikesamuel/regexp-div-ambiguity-fixes

*mikesamuel/regexp-div-ambiguity-fixes@2190 | mikesamuel | 2008-08-14
21:12:22 -0800 (Thu, 14 Aug 2008)

Description:

Implemented David-Sarah's suggested changes to lexing around '/'.

One of the tests in JsLexerTest is disabled by an if (false).

This is a known error that does not introduce a security vulnerability
since we do not require that our lexing is perfect -- we require that
our rendered output will be interpreted correctly.

Affected Paths:
   M //trunk/src/com/google/caja/lexer/JsLexer.java
   M //trunk/tests/com/google/caja/lexer/JsLexerTest.java

Original issue reported on code.google.com by mikesamuel@gmail.com on 15 Aug 2008 at 5:13

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 15 Aug 2008 at 5:43