amohata007 / Hacktoberfest

Just an initialisation for beginners to contribute for open source.
26 stars 296 forks source link

Is this really contributing to open source? #104

Closed bashbaugh closed 5 years ago

bashbaugh commented 5 years ago

@amohata007

Adding your name to a list is not really contributing to open source, in my opinion. What if you made it so that contributors have to make a little javascript widget/something like that in order to have their PRs accepted?

amohata007 commented 5 years ago

good idea @scitronboy ..but the fact is there are many beginners who even don't know how to create their first pr ...so for them its an initialisation..

bashbaugh commented 5 years ago

Okay. I think I might make a PR and add note to the README that encourages people to learn a language and make a code PR in a different repo along with this, because I do agree with you about this is a good first PR; however it seems like there are quite a few "first PR" repos created for Hacktoberfest and I think it needs to be clear that the goal of Hacktoberfest is to contribute to open source, not race to make the most quick PRs.

Closing this now.