amoikevin / adwhirl

Automatically exported from code.google.com/p/adwhirl
0 stars 0 forks source link

Does not tolerate missing custom adapter methods #107

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.  Release a version of your app
2.  In a new version, add a new custom adapter with a corresponding empty 
parameter method

What is the expected output? What do you see instead?

Old version will throw exception below and does not roll-over to other 
providers as expected.  We repeatedly see the error without the next provider 
being executed even if its 1% new custom adapter and 99% other adapter such as 
Admob presumably because the custom adapter is first in the JSON from the 
AdWhirl Server.

Expected output is that it should gracefully rollover missing adapter as if the 
error were due to a non-filled slot.

What version of the product are you using? On what operating system?

Android 2.2 OS, Adwhirl 2.5.4

Please provide any additional information below.

Caught exception in handle()
java.lang.NoSuchMethodException: adWhirlJumpTap
    at java.lang.ClassCache.findMethodByName(ClassCache.java:308)
    at java.lang.Class.getMethod(Class.java:985)
    at com.adwhirl.adapters.EventAdapter.handle(EventAdapter.java:55)
    at com.adwhirl.adapters.AdWhirlAdapter.handle(AdWhirlAdapter.java:124)
    at com.adwhirl.AdWhirlLayout.handleAd(AdWhirlLayout.java:214)
    at com.adwhirl.AdWhirlLayout.access$0(AdWhirlLayout.java:201)
    at com.adwhirl.AdWhirlLayout$2.run(AdWhirlLayout.java:137)
    at android.os.Handler.handleCallback(Handler.java:587)
    at android.os.Handler.dispatchMessage(Handler.java:92)
    at android.os.Looper.loop(Looper.java:123)
    at android.app.ActivityThread.main(ActivityThread.java:4627)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:521)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)
    at dalvik.system.NativeStart.main(Native Method)

Original issue reported on code.google.com by keithwri...@gmail.com on 23 Sep 2010 at 6:26

GoogleCodeExporter commented 8 years ago
Thanks for reporting. Will fix this in the next version.

Original comment by jpin...@google.com on 25 Sep 2010 at 12:51

GoogleCodeExporter commented 8 years ago
Fixed, will be part of release for v2.5.5.

Original comment by jpin...@google.com on 12 Oct 2010 at 10:18