search

amoilanen / Brackets-Command-Line-Shortcuts

Brackets IDE plugin. Adds support of shortcuts for execution of terminal commands right from the IDE.
8 stars 1 forks source link

Use PreferencesManager & replace spawn() with exec() #8

Closed eight04 closed 9 years ago

eight04 commented 9 years ago

Details:

  1. Use PreferencesManager to save configuration (in brackets.json) instead of writing into brackets-commandline.0.2.2.json in extension folder. This should fix #3. Default shortcuts are written in Configuration.js directly.
  2. Replace spawn() with exec() in node/run-command.js. Using spawn() on Windows cause double quotes issue: " will be escaped into \". Is there any side effect for *nix system?
  3. Update readme for (1).
  4. CommandManager is already defined in Configuration.js.
  5. Simulate PreferencesManager in spec/BracketsStubs.js.
amoilanen commented 9 years ago

Looks good, thank you for the contribution, it is much better to use the Preferences API than to create custom configuration files for the extension.

I will test the changes a bit and if there are no regressions will release them into the Brackets plugin repository soon. I will also add you into the list of the contributors, if you do not mind.