search

amol- / depot

Toolkit for storing files and attachments in web applications
MIT License
161 stars 41 forks source link

Add support for S3 StorageClass. Fixes #56 #57

Closed ghost closed 5 years ago

ghost commented 5 years ago

Add support for S3 StorageClass. Fixes #56

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-16.002%) to 81.88% when pulling 1f960f1570dd857535e134c33944624589fa640b on johnvencky:depot-s3-storageclass into 82104d2ae54f8ef55f05fb5a3f148cdc9f928959 on amol-:master.

amol- commented 5 years ago

Looks good to me, would you mind adding a test to verify that when you specify a storage class that it actually used?

ghost commented 5 years ago

Looks good to me, would you mind adding a test to verify that when you specify a storage class that it actually used?

Hey! Sorry for the delay -- it took me awhile to set up a proper test environment. :) Added a test to verify that when we upload 'STANDARD_IA', we get back the object of class 'STANDARD_IA'. Please take another look.

Also Alessandro, I wanted to ask about how often you create a release; it looks like last commit was back in January and no release is being planned soon? We are launching our project in September and I was wondering if S3 class support will be available; or should we plan to roll our own version of filedepot.

Thanks!

amol- commented 5 years ago

Thanks! Really appreciated this! I'll try to release this in the next few days.

amol- commented 5 years ago

0.7.0 released with support for storage class