search

amol9 / vlc-ctrl

A command line utility to control a running vlc player instance.
MIT License
13 stars 6 forks source link

Small improvement and exception handling #5

Open DanielGlaas opened 4 years ago

DanielGlaas commented 4 years ago

Hi amol9,

I came accross your tool and I found it very useful. While playing aroung, I decided that some small adaptions would make it even more better. Please take a look and decide whether you want to accept my proposals.

amol9 commented 4 years ago

Hi,

Thanks for trying out and improving vlc-ctrl. 🙂

Right now, for personal reasons, I'm on a rather long break from GitHub and programming. So, I won't be able to review and merge the changes for at least a few months.

I'll take a look as soon as I get back to it.

Regards, Amol.

On Sun, Jul 12, 2020, 11:51 PM DanielGlaas notifications@github.com wrote:

Hi amol9,

I came accross your tool and I found it very useful. While playing aroung, I decided that some small adaptions would make it even more better. Please take a look and decide whether you want to accept my proposals.

You can view, comment on, or merge this pull request online at:

https://github.com/amol9/vlc-ctrl/pull/5 Commit Summary

  • Add subcommand that allows to start a new VLC instance
  • Allow to play URLs too
  • Add some more command line options
  • Catch special exceptions that occure if no VLC instance is running
  • Add a fallback for streams with no entry in 'title'
  • Fix issue with launch command requested via SSH

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amol9/vlc-ctrl/pull/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA776PESY62X4NOHYXNVVLR3H5LRANCNFSM4OX5K6NQ .

DanielGlaas commented 4 years ago

Hi Amol, thanks for your reply. I didn't expect that we look into my PR within days as your last commit has been years ago. However, if you may find at some time to look into it I will appreciate it!

Thanks, Daniel

pseudo-usama commented 3 years ago

Hello, @DanielGlaas Can you add support for windows & Mac as Amol suggested in this issue.

DanielGlaas commented 3 years ago

Hello, @DanielGlaas Can you add support for windows & Mac as Amol suggested in this issue.

@pseudo-usama : I don't own a Mac so I have absolutely no skills on this field and also for Windows, I'm the right one to do that.